Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master deps 2024 09 06 13 40 04 783048 #1493

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Sep 6, 2024

No description provided.

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins no test

@cf-bottom
Copy link

@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from 21273e0 to 909bc07 Compare September 6, 2024 21:58
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins no test

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins no test

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

craigcomstock commented Sep 9, 2024

mingw retry Build Status

@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from 619556f to 6fd5732 Compare September 10, 2024 13:30
@craigcomstock
Copy link
Contributor Author

retry mingw build with fixed patch: Build Status

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins, think I'm ready for the tests

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

rhel7hub seems like a flake failure, rebuild: Build Status

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

seems static-checks job is flaky? Some error with assembler saying no such pseudo-op .uleb...

Build Status

@craigcomstock
Copy link
Contributor Author

jenkins checkboxes aren't clear, didn't run static-checks, retry again: Build Status

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins, full run again please, I think we should be "good"

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

see if the perl upgrade works. the build was working before this change so 🤞 Build Status

@craigcomstock craigcomstock marked this pull request as draft September 12, 2024 13:27
@craigcomstock
Copy link
Contributor Author

check all platforms including exotics, I suspect exotics might have some problems?
Build Status

@craigcomstock
Copy link
Contributor Author

Retry with openssl patch fix. Not sure why it wasn't failure elsewhere 🤔
Build Status

@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from e3d3a33 to 314b78f Compare September 17, 2024 21:34
@craigcomstock
Copy link
Contributor Author

Better patch, previous one didn't compile :) Build Status

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins full run, thanks.

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

oops, I need exotics, @cf-bottom jenkins with exotics please

@cf-bottom
Copy link

@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from 314b78f to f295858 Compare October 7, 2024 14:09
@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from f295858 to f4f4fbc Compare October 7, 2024 14:45
@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from f4f4fbc to ac54f41 Compare October 7, 2024 14:46
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins with exotics

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

hpux failure is seen by me before and now a ticket: https://northerntech.atlassian.net/browse/ENT-12366

@craigcomstock craigcomstock marked this pull request as ready for review October 8, 2024 03:20
@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from ac54f41 to 250424e Compare October 8, 2024 17:39
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Perl commits should be squashed. And there are more cherry-pick references to private commits in the commit messages. Looks good to me otherwise.

@@ -1 +1 @@
https://www.openssl.org/source/
https://github.com/openssl/openssl/releases/download/openssl-3.3.2/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain this in the commit message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to openssl bump commit message.

fi
if ! perl -e 'use List::Util qw(pairs);'; then
echo "$PERL has List::Util that does not export pairs. Needs to be at least version 1.29 for OpenSSL version 3.3.2."
PERL_OK="no"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change deserves a better commit message, IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the commit message, now part of openssl commit.

+maintenance_work_mem = 512MB # min 1MB
#autovacuum_work_mem = -1 # min 1MB, or -1 to use maintenance_work_mem
-#maintenance_work_mem = 64MB # min 64kB
+maintenance_work_mem = 512MB # min 64kB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the minimum is 1MB, our patched version should say that as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not. The maintenance_work_mem minimum is now 64kB. See this commit: postgres/postgres@bbf668d

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch of patch is always confusing...

Location of source tarballs has changed from www.openssl.org/source to github.com/openssl/openssl/releases/download.

openssl 3.3.2 requires perl List::Utils which exports pairs so change test in install-dependencies and build newer perl if needed.

fixup openssl windows patch, 0007 for openssl 3.3.2

Fixed openssl patch 0010 for openssl 3.3.2

Ticket: ENT-12140
Changelog: none
Preparation for changes needed in bumping postgresql from 16.3 to 17.0

Ticket: ENT-12140
@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from 250424e to 45371a7 Compare October 9, 2024 14:17
Adjusted postgresql release-monitoring ID to reflect current supported version 16.x

301832 was 15.x and we already upgraded to 16.3 recently on master.
https://release-monitoring.org/project/5601/ (PostgreSQL~current) was returning an RC version: 17 currently.
We didn't want that.
But now 17.0 is release so we will take it.
369409 pointed to 17 when it was an RC so also not helpful.

Adjusted postgresql.conf.cfengine.patch to work with changed postgresql.conf.sample.

Added new applications:
- The new application pg_combinebackup allows manipulation of base and incremental file system backups.
- Add application pg_walsummary to dump WAL summary files (Robert Haas)
- pg_createsubscriber, a utility that creates logical replicas from physical standbys
added --without-psl per information at:
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
curl/curl#14373
curl/curl#14379
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
added --without-psl per information at:
curl/curl#14373
curl/curl#14379
@craigcomstock craigcomstock force-pushed the master-deps-2024-09-06_13_40_04_783048 branch from 45371a7 to de704e5 Compare October 9, 2024 14:21
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@craigcomstock craigcomstock merged commit 8fbfb1b into cfengine:master Oct 9, 2024
@craigcomstock craigcomstock deleted the master-deps-2024-09-06_13_40_04_783048 branch October 9, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants